plugins/hunk: init #3293
plugins/hunk: init #3293
Conversation
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
from
80f89a2 to
54d3843
Compare
plugins/by-name/hunk/default.nix
Outdated
| extraOptions = { | ||
| fileTypeIcons = lib.mkEnableOption '' | ||
| Enable file type icons in the file tree. | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
I have missed something or this option is only used in the warning?
There was a problem hiding this comment.
Nope, only in the warning, I tried setting web-devicons to true there, but it threw a warning.
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
2 times, most recently
from
3de2637 to
714e66e
Compare
plugins/by-name/hunk/default.nix
Outdated
| extraOptions = { | ||
| fileTypeIcons = lib.mkEnableOption '' | ||
| warning if file type icons are not available. | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
Having an enable option for a warning feels like an anti-pattern
| extraOptions = { | |
| fileTypeIcons = lib.mkEnableOption '' | |
| warning if file type icons are not available. | |
| ''; | |
| }; |
There was a problem hiding this comment.
Removed the option!
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
from
714e66e to
286f4e0
Compare
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
from
286f4e0 to
bd1da3d
Compare
Adding myself as a maintainer
Add support for [hunk.nvim][1], a plugin for splitting diffs. Also add myself as a maintainer for it. [1]: https://github.com/julienvincent/hunk.nvim
jalil-salame
force-pushed
the
push-yxsyxkonwotv
branch
from
bd1da3d to
6926643
Compare
|
Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Add support for hunk.nvim, a plugin for splitting diffs.
Also add myself as a maintainer for it.